-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function calls with properties #114
Conversation
I tested it for Input, Also, @falkoschindler yes, I need to change all modules again :D Edit: The solution is smoother. |
… not critical for broadcast iteself
I added the most calls that only use one (or one with a default) parameter to be handled as a property by the proxy/expander. Some modules with multiple settings on different calls, like It works like this
It now does the same as @falkoschindler what do you think? |
I will add the documentation, once we finalize what has to be added or removed and how we add the call properties to the documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to put this PR on hold and evaluate a different approach, pausing the execution while booting a port expander. This would avoid the need for keeping track of methods and properties.
Should we archive this now? Since #117 is merged into main? @falkoschindler |
This will change the mute(), unmute() and broadcast() call, so they also work with properties.